search

GreycLab / gmic

GREYC's Magic for Image Computing: A Full-Featured Open-Source Framework for Image Processing
Other
66 stars 11 forks source link

Reverse Fourier Transform doesn't work for G'MIC installed as GIMP plugin #37

Closed CalculonPrime closed 4 months ago

CalculonPrime commented 6 months ago

To reproduce:

At the end of the above steps, the original image is not restored, so in fact the reverse FFT has not been applied correctly as the text instructions claim (they say "Note: Apply this filter once to get the direct FFT, and once again to get the reverse transform.").

Note that the above sequence succeeds in restoring the original image if you instead apply "Frequencies >> Fourier Transform [Old]", although the preview is invalid. (Should a separate bug be filed for the bad preview, or will bugs in the old version not be fixed?)

GIMP: 2.10.36 G'MIC: 3.3.3

dtschump commented 6 months ago

I've tried the filter with your image, and it works for me (see attached mp4 video). The filter generates two layers, so when you try to invert the transform, make sure the "Input Layer mode" is set to "All".

Video: https://github.com/GreycLab/gmic/assets/10114565/be7f966f-63ef-4beb-9a3d-7d6bb6ceb079

CalculonPrime commented 6 months ago

OK, thanks. I could've sworn I tried adjusting that with no change but I guess not.

However, the preview in the old Fourier transform is still broken. Is that something too minor to worry about?

dtschump commented 6 months ago

However, the preview in the old Fourier transform is still broken. Is that something too minor to worry about?

Yes, the preview is sometimes too small to get a correct preview with the "Old" version of the Fourier transform. Sometimes it works, sometimes not. The only thing I could do is just disabling the preview. Not sure this is better at the end.