search

Greymerk / minecraft-roguelike

This is a mod for minecraft that adds randomly generated dungeon complexes.
GNU General Public License v3.0
129 stars 53 forks source link

Compatibility with Sparse Structures. 1.21 #238

Open makumaku1974 opened 2 months ago

makumaku1974 commented 2 months ago

There is actually a massive problem with this mod. Somehow there are two Roguelike Dungeons a bit near to each other. Even with Sparse Structure installed.

image

Greymerk commented 2 months ago

While I agree that it'd be preferable for this to work, I'll have to look at the source code for sparse structures to see if it's even possible. My mod isn't technically a structure, it's more like a unique chunk feature pretending to be a structure.

makumaku1974 commented 2 months ago

While I agree that it'd be preferable for this to work, I'll have to look at the source code for sparse structures to see if it's even possible. My mod isn't technically a structure, it's more like a unique chunk feature pretending to be a structure.

oh i see, but I think it would be better if you set a config for it to be rare than relying with the sparse structure in that case.

Greymerk commented 2 months ago

I already figured out how to fix this and the fix works. I have some work to do to clean up the solution, but yeah. I just needed to pull the placements from the dynamic registries, which sparse structures hooks into.

Thanks for pointing this problem out.

makumaku1974 commented 2 months ago

No problem glad to help. It was a bit rare though seeing two together, but if I had more structure mods. Roguelike Dungeons actually becomes rare but this time i only had battle towers which is a datapack and Roguelike dungeons.