search

Greymerk / minecraft-roguelike

This is a mod for minecraft that adds randomly generated dungeon complexes.
GNU General Public License v3.0
130 stars 53 forks source link

Dungeons generating in all dimensions even though only 0 is whitelisted #57

Closed RealGrep closed 8 years ago

RealGrep commented 8 years ago

I'm seeing dungeons in the nether, and the end (which obviously doesn't work well). However, the config file seems to only whitelist dimension 0. So there seems to be a bug there.

The config file generated on the server at config/roguelike_dungeons/roguelike.cfg, and contains the lines (among others):

dimensionBL= dimensionWL=0

As far as I can see, they should only generate in the overworld, but I still get them everywhere.

This is in 1.9.4 with RoguelikeDungeons-1.9.4-1.5.2.jar and forge 1965.

Thank you :)

oldjunyi commented 8 years ago

I met the same issue in my server: dungeonintheend

Greymerk commented 8 years ago

It's a bug I introduced when I changed how settings are resolved, and criteria is evaluated. I believe I've fixed it. Will check to make sure everything works properly now and post a new version.

RealGrep commented 8 years ago

Thanks, will test it when it's out. :)

Greymerk commented 8 years ago

Hopefully fixed in this update https://github.com/Greymerk/minecraft-roguelike/releases/tag/v1.5.3

RealGrep commented 8 years ago

I deleted the End and Nether and flew around for a good while, earlier. So far, so good. I think you got it. If I find any, I'll let you know, of course. I could have gotten super unlucky in my tests. Thanks for working on it! I appreciate it.

RealGrep commented 8 years ago

Just noticed this is still open. I've played a long time with it since then, and have not seen a single instance of the dungeons generating in the Nether or End. So I can conclusively say it's fixed. Closing. Thanks again!