search

Greymerk / minecraft-roguelike

This is a mod for minecraft that adds randomly generated dungeon complexes.
GNU General Public License v3.0
130 stars 53 forks source link

Specifying Rooms Causes Halls to Become 3x3 Corridor with Nothing in It #84

Closed Alan19 closed 7 years ago

Alan19 commented 7 years ago

2017-01-20_23 31 01

Link to JSON: http://pastebin.com/ek6C697x

EnderStar commented 7 years ago

I think that there are too many rooms for such a small range so they dont fit and this happens. try increasing the range to 100 to test and decrease it until this starts to happen to get the minimum range

Alan19 commented 7 years ago

I decreased the number of rooms to 10 and increased the range to 100 and it's still happening 2017-01-22_15 58 54

Here is the json I'm using:http://pastebin.com/tWmHCusA The part with the rooms is near the bottom from line 287-297

Greymerk commented 7 years ago

Ok, I'll admit this is kinda my fault. "single" "random" apparently is case sensitive and needs to be lower case.

It really shouldn't be case sensitive, I know.

Doesn't explain why the hallways are blank though. I wasn't able to reproduce that issue.

Alan19 commented 7 years ago

Maybe it's because I'm using Foamfix anarchy edition

Alan19 commented 7 years ago

I'm going to test it right now

Greymerk commented 7 years ago

Your screenshot kinda looks like the result of a crash part way through the dungeon generation. It actually looks rather like the generator finished creating the hallways and then stopped before creating the rooms and hallway decorations.

Alan19 commented 7 years ago

I got it to work after adding the changing single and random to lowercase. The only thing I changed from the first time was increasing the range and decreasing the number of rooms in the level settings.

Alan19 commented 7 years ago

It seems that adding room replaces the rooms that would spawn normally completely without overriding. Is this intended?

Greymerk commented 7 years ago

It's a behavior I never got around to implementing. Currently if you specify a list of rooms it just overrides all the rooms for that level.

Alan19 commented 7 years ago

By the way, you didn't list the reward room on the wiki and do you know which rooms contain items from the block list @Greymerk ?

Alan19 commented 7 years ago

I'm also getting this in B2 even though I increased the floor size

Greymerk commented 7 years ago

I used to put "Block" chests more commonly in the dungeon. Now they're only in the storage room as i recall.

Greymerk commented 7 years ago

Regarding this bug, I think what I'll try to do is make the system throw a warning if an invalid name is given.

Alan19 commented 7 years ago

I got an error log when this happened on B2

Alan19 commented 7 years ago

Trying to find it right now

Greymerk commented 7 years ago

probably just says "null"

Greymerk commented 7 years ago

I've implemented this enhancement in the latest build to provide meaningful warnings if an incorrect name is given.