search

GribApiDotNet / GribApi.NET

A powerful .NET library for reading and writing GRIB 1 and 2 files
Apache License 2.0
54 stars 28 forks source link

EnableMultipleFieldMessages Detection #49

Closed IdahoSixString closed 7 years ago

IdahoSixString commented 7 years ago

As previously noted in #29 and #47 it seems to be a common issue to have to enable EnableMultipleFieldMessages. Maybe the when running the a similar method to FileIsValid we could detect if EnableMultipleFieldMessages needs to be set to true or not. Thoughts?

0x1mason commented 7 years ago

I'm not sure how to do this. I'm considering making it the default

0x1mason commented 7 years ago

@IdahoSixString I figured out how to do this. Do you have a file I can use for tests?

0x1mason commented 7 years ago

@IdahoSixString @jnyrup @silv2015 Can one of you provide or refer a service that can provide a grib file that contains at least 2 messages that do not work correctly without EnableMultipleFieldMessages enabled? I need one to test the new auto-detection feature, but I'm having difficulty locating one.

Many thanks for your help and interest in the project.

IdahoSixString commented 7 years ago

WRFPRS_NAM_00z_d01.000.zip

@0x1mason Here you go this file will require that you have EnableMultipleFieldMessages enabled.

0x1mason commented 7 years ago

@IdahoSixString Thanks.

silv2015 commented 7 years ago

Sorry but All the files I have are at least 50mb, I can ask my service provider for a smaller file if you still need it?

0x1mason commented 7 years ago

@IdahoSixString @silv2015 I ended up just enabling it by default. The grib_api docs caution against it, but several of the other wrapper libs I've seen do it and having it disabled has been a major source of confusion.

The context object is static, so trying to dis/enable dynamically could cause surprising behavior when dealing with the multiple files at the same time. Not worth.

As always, I appreciate your help.

IdahoSixString commented 7 years ago

@0x1mason Can you please upload your new beta package to NuGet? I only see the 1.0 beta on NuGet.

0x1mason commented 7 years ago

@IdahoSixString Check now

jnyrup commented 7 years ago

@0x1mason beta is still listed as the neweset pre-release: https://www.nuget.org/packages/Grib.Api/

IdahoSixString commented 7 years ago

Still only see 1.0.0-beta.

From: Jonas Nyrup notifications@github.com Sent: Tuesday, August 1, 2017 12:29:46 AM To: 0x1mason/GribApi.NET Cc: IdahoSixString; Mention Subject: Re: [0x1mason/GribApi.NET] EnableMultipleFieldMessages Detection (#49)

@0x1masonhttps://github.com/0x1mason beta is still listed as the neweset pre-release: https://www.nuget.org/packages/Grib.Api/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/0x1mason/GribApi.NET/issues/49#issuecomment-319280558, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFGk7mIxQrqhHnl_gO39UMNe4mEgOq0rks5sTsXagaJpZM4M3Gat.

0x1mason commented 7 years ago

@IdahoSixString @jnyrup It's definitely there now.

IdahoSixString commented 7 years ago

I see it there now. What happened previously?

From: Eric Millin notifications@github.com Sent: Tuesday, August 1, 2017 6:35:47 PM To: 0x1mason/GribApi.NET Cc: IdahoSixString; Mention Subject: Re: [0x1mason/GribApi.NET] EnableMultipleFieldMessages Detection (#49)

@IdahoSixStringhttps://github.com/idahosixstring @jnyruphttps://github.com/jnyrup It's definitely there now.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/0x1mason/GribApi.NET/issues/49#issuecomment-319534780, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFGk7skPr313s2yEAH0B1fd_-485bBVXks5sT8RjgaJpZM4M3Gat.