search

GribApiDotNet / GribApi.NET

A powerful .NET library for reading and writing GRIB 1 and 2 files
Apache License 2.0
54 stars 28 forks source link

Rename Method Clone To Copy #60

Closed IdahoSixString closed 7 years ago

IdahoSixString commented 7 years ago

This really isn't a clone but rather a shallow copy of the data the underlying references are the same.

Here is a good definition of the difference between copy and clone (https://stackoverflow.com/questions/2200409/what-is-the-difference-between-copying-and-cloning)

0x1mason commented 7 years ago

Clone is the name of the grib_api function it wraps (well, really grib_handle_clone).

0x1mason commented 7 years ago

I'm inclined to leave the named unchanged, but I will at leased add more to the Intellisense docs

IdahoSixString commented 7 years ago

@0x1mason I believe including more intellisense docs is good.

0x1mason commented 7 years ago

@IdahoSixString On second thought, I agree with your suggestion and have made the change. Thanks for pointing out that this was actually a shallow copy.