search

Gribbleshnibit8 / xcom2-launcher

Unofficial XCOM 2 launcher
GNU General Public License v3.0
12 stars 4 forks source link

Version mismatch #3

Open WalrusInAnus opened 7 years ago

WalrusInAnus commented 7 years ago

When I start the program, I get a popup telling me the current version is 0.4.4 and new one 1.0.0, but that's not what GitHub says.

Gribbleshnibit8 commented 7 years ago

This will be fixed in the next version. Finally figured out how the version thing works.

velit commented 7 years ago

This bug still exists as of the newest version, which the updater thinks is 1.0.2 even though version on github says 1.0.1 and so does the release zip.

Littlebob86 commented 7 years ago

untitled

Gribbleshnibit8 commented 7 years ago

Yep, sure does. I really don't understand the version thing (the project that it's from has documentation that basically says not to use it how it's being used here. I will probably just disable it and do something else because I just don't know...

Littlebob86 commented 7 years ago

So am I ok to reassign all my mods, or are you likely to update the launcher again and I lose all my categorised mods?? :)

BTernaryTau commented 7 years ago

Backup your settings.json file if you want to be sure you don't lose your categories.

Littlebob86 commented 7 years ago

Much appreciated :)

Sent from my Samsung Galaxy smartphone.

-------- Original message -------- From: BTernaryTau notifications@github.com Date: 15/03/2017 03:42 (GMT+08:00) To: Gribbleshnibit8/xcom2-launcher xcom2-launcher@noreply.github.com Cc: Littlebob86 Littlebob86@hotmail.com, Comment comment@noreply.github.com Subject: Re: [Gribbleshnibit8/xcom2-launcher] Version mismatch (#3)

Backup your settings.json file if you want to be sure you don't lose your categories.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/Gribbleshnibit8/xcom2-launcher/issues/3#issuecomment-286537323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYxc8KBPqVIRR2yta2NAXPbRrht7LcRKks5rlu20gaJpZM4L8FH0.

kwstannard commented 7 years ago

I took a crack at tracking this down. So, the current version number is gotten from XCom2Launcher.GitVersionInformation. I can't find this defined anywhere. There is, however, a GitVersionConfig.yaml, but the values within do not seem to be used anywhere.

Have you tried explicitly setting "v1.0.1" as the return value of GetCurrentVersion and seeing if that fixes the bug? I am guessing that is probably not ideal, but I don't know how to use C#.

What this doesn't answer is where the value "v1.0.2" comes from. I can't find this reference in the code anywhere and doesn't come from the github json information either.

ghost commented 7 years ago

FYI guys, this was forked and current launcher maint. is below

https://github.com/X2CommunityCore/xcom2-launcher