Grid2op / chronix2grid

https://chronix2grid.readthedocs.io/en/latest/?
Mozilla Public License 2.0
19 stars 5 forks source link

Year 2017 is always taken for reference when generating loads #45

Open BDonnot opened 2 years ago

BDonnot commented 2 years ago

When you want to generate loads for a given period, for example with:

chronix2grid --mode RL --output-folder /home/donnotben/Documents/chronix2grid_gaetan/getting_started/experiments/../example/custom/output --input-folder /home/donnotben/Documents/chronix2grid_gaetan/getting_started/experiments/../example/custom/input --ignore-warnings --weeks 1 --case case118_l2rpn_wcci_benjamin --n_scenarios 1 --start-date 2048-06-01 --seed-for-loads 1791095845  --seed-for-res 1616579073

The 2048-06-01 is a monday. However the load profile for this command is:

20220225_Load_generee

Which clearly starts a Thursday (week-end after 2 days) and NOT a monday.

The profile is obtained regardless of the year.

BDonnot commented 2 years ago

The current behaviour is to hard code in the compute_loads function the lag (in number of days).

It is currently set to 6 corresponding to a "proper year" 2050

marota commented 2 years ago

Day_lag has been introduced to deal with that. https://github.com/BDonnot/ChroniX2Grid/blob/237a41ccce77cd60e91bb154f24e0e6996aa58db/chronix2grid/generation/consumption/consumption_utils.py#L27

But still need a bit of work to work properly end-to-end. For now it is hard coded to day_lag=6 for year 2050