GridProtectionAlliance / osisoftpi-grafana

Grafana Data Source Plugin for the OSIsoft PI System
https://grafana.com/plugins/gridprotectionalliance-osisoftpi-datasource
Apache License 2.0
58 stars 30 forks source link

Datasource issue #3

Closed alqassak closed 6 years ago

alqassak commented 7 years ago

Hi, when I try to add a metric from AF datasource: image image

In the element the plugin add's select metric image

when I remove the select metric in the toggle edit mode image

and then add the element again image

It will work image

When ever i need to edit a dashboard i have to do all these steps again because once you click on metrics its going to be reset and will show the value as N/A

Thanks, Khalil

alqassak commented 7 years ago

Hi, this same issue is causing IE not to display the reading from the datasource, I've mentioned it in Grafana Group and Torkel told me that it's datasource issue, here is the link to the conversation https://groups.io/g/grafana/topic/internet_explorer_ie_issue/4401818?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,4401818

Hi, We can see data in Chrome but we don't see it in IE

example: image

the above screenshot is from chrome image

IE screenshot image

also, if I login as admin in chrome it will reflect directly and will give me access to edit and add new display but in IE, I see the admin menu but when clicking on the singlestat to edit, the edit button doesn't appears,

Please note that I'm using IE version 11 Thanks, Khalil

Can you open IE developer tools and check for error in js console? Think IE 11 could be a bit too old, there are some open issues with Ie 11. You will l have better luck with Edge, chrome and Firefox.

Cheers Torkel

Hey Torkel, This is the error that i'm receiving in the console, image

Regards, Khalil

Strange, it's not a Javascript issue but the datasource request returns an error. /Torkel

alqassak commented 7 years ago

Dear @EEParker / @ritchiecarroll , Could you please help me with the above,

Thank you so much,

Regards, Khalil AlQassab

ritchiecarroll commented 7 years ago

Does this work in Chrome?

EEParker commented 7 years ago

I do not have a solution for this at the moment, however I am looking into the issue. Can you send a screenshot of your PI datasource connection settings and what version of Grafana you are using? Please black out server names.

alqassak commented 7 years ago

@EEParker

untitled

We are using Grafana 4.1.1

RobertZomborszki commented 7 years ago

Hi, I've just started to use Grafana and this PI plug-in, and this issue is making problems for me too.

If I use the metrics configuration pane the "select metric" is also end up in the AF element path: Gas\California\PW01\select metric|dGasVolume and of course the PI WebAPI cannot find the attribute.

EEParker commented 7 years ago

https://github.com/GridProtectionAlliance/osisoftpi-grafana/commit/d6fd5e0cd8a2fbdf84163a20f75f80e6948e060a has some updates that might fix this issue. The plugin on Grafana website should be updated shortly, or you can try using the contents of the distribution folder here: https://github.com/GridProtectionAlliance/osisoftpi-grafana/tree/master/dist

alqassak commented 7 years ago

@EEParker

I've tried the updates and it didn't work, with the updates I cannot read anything from PI as well when creating a new Graph in a display the selection for the element and metric they disappear, capture

alqassak commented 7 years ago

Dear @EEParker

Any update?

Regards,

alqassak commented 7 years ago

@EEParker It's been a while since your last response, is there any update regarding the mentioned issue?

iotgopher commented 7 years ago

hi @ritchiecarroll have you guys tried the plugin when running grafana on https? Any particular setting is needed? We are getting a 403 error Thanks a lot

ritchiecarroll commented 7 years ago

I've not tried the OSI plug-in on HTTPS, maybe @EEParker has... I'll see if I can get it working when I get back to the office...

iotgopher commented 7 years ago

What looks like from our tests is that it works with PI Web Api 2016 but on PI Web Api 2017 it breaks in https mode

EEParker commented 7 years ago

We are currently using PI WebAPI 2017 (part of PI Vision) over HTTPS. I'm not sure if this will help, but perhaps some of these settings may help your issue.

Here are some screenshots of our configuration:

Note: CorsOrigins * is for testing. Use real servers preferred.

image

image

alqassak commented 6 years ago

Dear @EEParker / @ritchiecarroll

We were able to fix the issue's above by modifying the query_ctrl files,

In the files "osisoftpi-grafana-master\dist\query_ctrl.js" and "osisoftpi-grafana-master\dist\query_ctrl.js.map" This statement _this.target.target = _this.target.target || 'select element'; Was replaced with _this.target.target = _this.target.target || ‘;';

In file osisoftpi-grafana-master\dist\query_ctrl.js
This statement ctrl.segments = ctrl.segments.splice(0, fromIndex); if (ctrl.segments[ctrl.segments.length - 1].expandable) { ctrl.segments.push(ctrl.uiSegmentSrv.getSegmentForValue(null, "Select AF Database")); } Was replaced with ctrl.segments = ctrl.segments.splice(0, fromIndex+1); if (ctrl.segments[ctrl.segments.length - 1].expandable) { ctrl.segments.push(ctrl.uiSegmentSrv.getSegmentForValue(null, "Select AF Database")); }

And osisoftpi-grafana-master\dist\query_ctrl.js.map This statement ctrl.segments = ctrl.segments.splice(0, fromIndex)\n if (ctrl.segments[ctrl.segments.length - 1].expandable) {\n ctrl.segments.push(ctrl.uiSegmentSrv.getSegmentForValue(null, \"Select AF Database\"))\n }\n Was replaced with ctrl.segments = ctrl.segments.splice(0, fromIndex+1)\n if (ctrl.segments[ctrl.segments.length - 1].expandable) {\n ctrl.segments.push(ctrl.uiSegmentSrv.getSegmentForValue(null, \"Select AF Database\"))\n }\n