GridSpace / grid-apps

Browser-based Slicer for 3D Printing, CAM, Laser (Kiri:Moto) and mesh editor (Mesh:Tool)
https://grid.space/
MIT License
446 stars 141 forks source link

base fan in belt mode not applied at the right times #217

Closed stewartoallen closed 1 year ago

stewartoallen commented 1 year ago

it should only enable the fan when the extrusion is touching the belt. there is interplay with the fan setting off belt that also needs to be resolved

stewartoallen commented 1 year ago

fixed with a caveat. only values > 0 will trigger base fan overrides. 0 has a special meaning in fields and is reserved for "use default value". for all other fields, this makes sense. fixing this would require the introduction of another checkbox in the ui as well as new code to check for it. for now, use 1 as 0 for the base fan value to turn off the fan.

it is possible to use the literal 0 which is the default for base fan in belt mode. however, this would induce fan toggling on/off twice on every layer, which may stress fans and produce undesirable results on corners if fans spin up slowly.