GridSpace / grid-apps

Browser-based Slicer for 3D Printing, CAM, Laser (Kiri:Moto) and mesh editor (Mesh:Tool)
https://grid.space/
MIT License
459 stars 143 forks source link

CAM designs using tabs use the default machine camFastFeed and camFastFeedZ for operations on tab layers #250

Closed KeanWong closed 1 year ago

KeanWong commented 1 year ago

For designs that use tabs (tested with an outline operation), the plunge rate and feed rate used for the tab layer cutouts are set to camFastFeed and camFastFeedZ (2000 and 500), irrespective of what the feed rate for the milling operation is. I think that the issue is in the logic around this line https://github.com/GridSpace/grid-apps/blob/b35d5440a1d82460d43879db4024494e6b559d48/src/kiri-mode/cam/ops.js#LL462C27-L462C27 , using offset (which appears to be 0 for tabs) as the cut parameter of camOut https://github.com/GridSpace/grid-apps/blob/b35d5440a1d82460d43879db4024494e6b559d48/src/kiri-mode/cam/prepare.js#L298, which causes isMove = true, and this causes the rate to be set to plungeRate in line 405 (which is camFastFeedZ). Ditto for the feed(rate), which is camFastFeed. tab-issue.zip