GridSpace / grid-apps

Browser-based Slicer for 3D Printing, CAM, Laser (Kiri:Moto) and mesh editor (Mesh:Tool)
https://grid.space/
MIT License
456 stars 143 forks source link

Roughing / pockets - only the edges are done, center is missed #57

Closed rqhub closed 4 years ago

rqhub commented 5 years ago

The 3 square pockets in this example are 8mm wide, with a 3mm bit. They should be 3 passes per level, the algo just makes 2, leaving a stud in the middle Same result with and without depth first STL herebelow

Also, travel moves (i don't have the example here), are sometimes done at the wrong z level, provoking crashes (we had this issue some time ago)

rqhub commented 5 years ago

Sorry, can't neither edit the text, neither attach files. Thank Microsoft. Will send them by mail if you need them.

Imgur images here: https://imgur.com/edN8AdP

stewartoallen commented 4 years ago

Can you verify if this is still the case? This code has been substantially re-written.

ramkam commented 4 years ago

The issue is back. It's missing parts of the roughing. Files & screenshots hereafter [there:](url

Capture d’écran 2020-06-01 à 21 29 40 Capture d’écran 2020-06-01 à 21 28 21

cnc163.zip

)

ramkam commented 4 years ago

Note that with a stepover of 0.7 instead of 0.8 it seems to work better. There's definitively an issue though, maybe to taking the last item of an array (improper bound) or by design / way of calculating the path vs tolerances ... anyway, these bugs come back often, i wonder if it's opportune to make more elaborate tests before pushing the release into prod?

Capture d’écran 2020-06-01 à 21 38 04

?

stewartoallen commented 4 years ago

I don't think anything has changed recently that would cause this. I'm in the process of re-doing the back end to allow for multiple version of Kiri to be hosted simultaneously. That way you can choose which release you want to work with. It will also allow me to have a live branch with highly experimental code.

ramkam commented 4 years ago

Sounds good to me! Carefull on not maintaining to many versions in parallel, it's a nightmare

I wonder if there's a way to isolate the slicing & gcode generation from the gui? for ex, calling the slice+gcode from CLI with a reference to a json config file > outputs gcode ? (as you guessed i'm not up to date in js/node coding :D)

stewartoallen commented 4 years ago

in this case, the code that's changing would not be in the UI

ramkam commented 4 years ago

the last point is completely unrelated to the bug. i'm just wondering how to make things more convenient in my "workflow"

ramkam commented 4 years ago

anyway, don't bother too much, your app is tip top, it does the job good enough, and i haven't encountered bits collisions for a long time now. Thanks.

ramkam commented 4 years ago

Ok, it happens again, on other models, collisions are back. Luckily that one wont break the bit.

Capture d’écran 2020-06-02 à 22 45 23 Capture d’écran 2020-06-02 à 22 48 24 Capture d’écran 2020-06-02 à 22 48 13

cnc166.zip

ramkam commented 4 years ago

cnc166.zip

stewartoallen commented 4 years ago

Can you also send the settings that produced this? Setup -> Export

ramkam commented 4 years ago

kiriconf.b64.zip

ramkam commented 4 years ago

Somehow, those (crappy) long bits are expensive :-)

My isssue is that i really rely on what the CAM is expected to do, otherwise i can endup crashing at best into soft material, at worst into nuts & bolts ...

I'm tempted to writing some (python, sorry, already did some voxel stuff in that) code to do collision & bit over loading detection :D

Capture d’écran 2020-06-02 à 23 00 06

Is there a more stable version i can download & use locally?

stewartoallen commented 4 years ago

do you see this in the cut or only in the simulator? i've regenerated the gcode and looked at the one your sent and while I see that diagonal move, it doesn't seem to intersect uncut material in my previewer.

ramkam commented 4 years ago

not crazy, there were some weird moves, so i replayed it on the simulator, and when i saw the picture above, i stopped it before i had to see a crash or step skips ...

this said, the CAMotics app never failed me before ran it twice, at different resolutions, same same and checked quickly, it's making a 3 mm deep cut, at 100% load, instead of 1 mm

ramkam commented 4 years ago
Capture d’écran 2020-06-03 à 02 07 08 Capture d’écran 2020-06-03 à 02 04 36
stewartoallen commented 4 years ago

there must be a bug in my visualizer and collision detection. will work on it.

ramkam commented 4 years ago

Wild guess (i don't know how your algo is made): operations to executre are grouped, and the group is stored in a pile. Then, a decision is made to make one group or the other from the pile; not always the right one; or the length of the pile is miscalc / some op groups stay stuck

stewartoallen commented 4 years ago

sort of. it's a bit more complex than that because of the way pools (nested groups) can split top down. but this error appears to be in the z height detection of interference between pools.

stewartoallen commented 4 years ago

A fix has been pushed to production