Improve neighbor loads in `horizontal_shift` of `gtfn`

GridTools / gridtools

Libraries and utilities to develop performance portable applications for weather and climate.

https://gridtools.github.io/gridtools

Other

61 stars 21 forks source link

Improve neighbor loads in `horizontal_shift` of `gtfn` #1779

Closed iomaganaris closed 4 months ago

iomaganaris commented 5 months ago

Define separately neighbor variable to avoid extra memory loads in horizontal_shift()

gridtoolsjenkins commented 5 months ago

Hi there, this is jenkins continuous integration... Do you want me to verify this patch?

iomaganaris commented 5 months ago

launch jenkins

iomaganaris commented 5 months ago

launch perftests

fthaler commented 5 months ago

Another thing I noticed: the data layout of the ‘default’ neighbor tables (that is, arrays of tuples) is actually pretty bad: it does not allow for coalesced loads in a reasonable way and does not guarantee any alignment.

iomaganaris commented 5 months ago

launch perftests

iomaganaris commented 5 months ago

launch jenkins

iomaganaris commented 4 months ago

Superseded by #1785 since this PR is problematic