refactor: Remove stale references to flake8

GridTools / gt4py

Python library for generating high-performance implementations of stencil kernels for weather and climate modeling from a domain-specific language (DSL).

https://GridTools.github.io/gt4py

BSD 3-Clause "New" or "Revised" License

111 stars 49 forks source link

refactor: Remove stale references to flake8 #1625

Closed romanc closed 2 months ago

romanc commented 2 months ago

Description

In PR https://github.com/GridTools/gt4py/pull/1466, flake8, black, and isort were replaced with the ruff linter and formatter. It seems there are a few leftovers of this transition. In this PR, I did a quick search for flake8 and deleted / replaced all instances found.

Removing flake8 means rebuilding the requirements (to propagate the changes to the frozen requirements-* files), which updates a couple of dependencies.

We also decided to remove the linter-* tasks of tox since they have been replaced by pre-commit.

Requirements

[ ] All fixes and/or new features come with corresponding tests: N/A
[ ] Important design decisions have been documented in the approriate ADR inside the docs/development/ADRs/ folder: N/A

If this PR contains code authored by new contributors please make sure:

[x] The PR contains an updated version of the AUTHORS.md file adding the names of all the new contributors.

egparedes commented 2 months ago

Thanks for contributing with this PR to clean up GT4Py!

@egparedes / @havogt: How can I propagate changes from requirements-dev.in to auto-generated files like requirements-dev.txt?

Just run: tox r -e requirements-base. More details here: https://github.com/GridTools/gt4py/blob/main/docs/development/tools/requirements.md

romanc commented 2 months ago

@egparedes thanks for the quick reply and the pointers. I could run the tox command to update the requirements and I checked the mypy version for consistency. This should be ready for review now.

/cc @FlorianDeconinck

egparedes commented 2 months ago

I hadn't realized that the CI checks were waiting for explicit approval of a member of the developers' group and didn't run automatically. I've triggered them now and as soon as they finish I'll approve the PR. In the meantime, please merge back the changes from main in this PR to make sure everything works fine.

romanc commented 2 months ago

@egparedes Thanks for starting the tests. I rebased my branch on top of main. Looks like this stopped the ongoing CI and now tests are waiting again for approval to run. I guess you'll need to manually start them again :/

egparedes commented 2 months ago

cscs-ci run default

egparedes commented 2 months ago

@romanc Thanks again for your contribution. I've approved and already merged the PR myself because I want to add these changes to another PR I'm working on.

romanc commented 2 months ago

Thanks for merging @egparedes. Happy to contribute!