search

GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 377 forks source link

Infinite scroll throws exception with latest chrome #557

Open tarelli opened 7 years ago

tarelli commented 7 years ago

It used to work fine before updating Chrome to the latest, now with Version 56.0.2924.76 there is an exception Maximum Call stack exceeded. Have other people encountered this? Thanks!

screen shot 2017-01-28 at 12 55 19

gidili commented 7 years ago

Getting the same with latest chrome on 0.6... the error seems to be gone with an upgrade to 0.7.1, but still when infinite scrolling through loads of items griddle gets stuck for a while then eventually recovers but no max stack calls in the console anymore.

bjoe87 commented 7 years ago

How many columns do you have during this? I seem to be running into the same issue with the upgrade to 0.7.1. Noticed this issue isn't there when there are ~5 columns with single values that do no span multi lines. As soon there are more columns or cells with massive values; the call stack error appears.

What seems to be happening is that it gets stuck calling the gridScroll() as the values it checks against jumps back and forth so it gets stuck setting the new state with different values since gridScroll() is also in the componentDidUpdate.

I increased the adjustedRowHeight() a little and that seemed to resolve the issue.

ryanlanciaux commented 7 years ago

@joellanciaux Could you please look into this one?

ChandraSekharTiwari commented 7 years ago

@gidili For me what you said is not working

avivr commented 7 years ago

We're having the same problem, you can see demo here - http://codepen.io/rosentalaviv/full/ZLdLLq/ It seems to be related to the variable rows height. It does not occurs you specify rowHeight property and make sure all rows are set to this height.

vozni4iy commented 7 years ago

If row heights are different this method doesn't work. Does anybody know is this bug already fixed in 0.8? Is there infinite scroll implementation in griddle 1.2.0?

bjoe87 commented 7 years ago

Any progress on this?

gidili commented 7 years ago

@ryanlanciaux thinking to attempt an upgrade to 1.x to resolve this (and other infinite scrolling issues with loads of data and/or variable row heights) - can I ask if you have any indication that in more recent version infinite scrolling is more robust? Using pagination right now to get around some issues but would really like to use this feature as it's awesome! 😄

bjoe87 commented 7 years ago

check the fork I have; this may have been fixed in mine. Let me know if it works for you @gidili