search

GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 377 forks source link

PositionPlugin not working #709

Open jrmartin opened 7 years ago

jrmartin commented 7 years ago

Griddle version

1.3.1

Expected Behavior

I'm using the Position Plugin from this repository https://github.com/GriddleGriddle/griddle-position-plugin, the expected behavior is to include it in the plugins setting of the Griddle and set the Griddle's table height.

Actual Behavior

The actual behavior is that once I add the Position Plugin, the Griddle component fails to render with the following error: error-pos-plugin

Steps to reproduce

I made a codepen with the behavior https://codepen.io/jrmartin/pen/xLORVJ I commented out the plugins line when rendering the Griddle, if that line is uncommented then the error happens.

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

dahlbyk commented 7 years ago

That repo seems to be obsolete. The plugins.PositionPlugin is now included and exported from the module, with an example story.

jrmartin commented 7 years ago

Cool, using the plugins from plugins.PositionPlugin works. I can now set the table height to be whatever I want and the scroll bar is there. One issue I'm still having, is that if I'm rendering 200 rows, all these rows are shown at once in the table. Is there a way to only load/show say 10 rows first and then keep loading the rest of the rows only until the user starts scrolling down the page?

mihirsoni commented 6 years ago

@dahlbyk I guess this issue still persist. We don't have way for true infinite scroll I guess ?

Wizard2007 commented 6 years ago

@dahlbyk I have the same problem now

dahlbyk commented 6 years ago

@mihirsoni @Wizard2007 can you clarify what your problem is? The built-in PositionPlugin is certainly limited (e.g. it only works with LocalPlugin, too), but we're open to improving it.