Add Storybook to build + fix connect type definition

GriddleGriddle / Griddle

Simple Grid Component written in React

http://griddlegriddle.github.io/Griddle/

MIT License

2.5k stars 378 forks source link

Add Storybook to build + fix connect type definition #724

Closed dahlbyk closed 7 years ago

dahlbyk commented 7 years ago

Griddle major version

1.8

Changes proposed in this pull request

[x] Make build fail if TypeScript Storybook won't build.
- Not sure if there's really any value to targeting dist/examples/storybook.js rather than throwing the output away.
- It seems like build-storybook should have been sufficient, but it doesn't recognize JSX. So we're going with a straight webpack for now.
[x] Fix type definition for new connect - I didn't have a chance to test #722, but it's not happy

Why these changes are made

The build should break if types are broken.
The types should not be broken.

Are there tests?

Kind of?

ryanlanciaux commented 7 years ago

I will try to upgrade in one of my projects that uses TypeScript today :| I did from an npm packed version and on npm before making 1.8.0 the release version.

dahlbyk commented 7 years ago

@ryanlanciaux following up on this... 1.8.0 is essentially broken with TS without these fixes. There are a few other bigger changes pending, but could you ship a 1.8.1 release if this looks good?

ryanlanciaux commented 7 years ago

Absolutely - this looks good to me. Merging and will ship a new version tonight.

ryanlanciaux commented 7 years ago

Hmm may be tomorrow before shipping new version -- I'm currently getting this https://travis-ci.org/GriddleGriddle/Griddle/builds/270145494 because I didn't test against this ahead of latest master, I think (sorry!).

I'll fix the part that's causing the failure and then push a new version.

dahlbyk commented 7 years ago

Fixed: https://github.com/GriddleGriddle/Griddle/pull/732

ryanlanciaux commented 7 years ago

1.8.1 is out but not pushed as latest -- I'm testing on some more of my production projects before doing that.

There might be an issue with the new griddle-connect that I'm trying to track down as well BUT if not, I'll push this one as latest very soon (won't go a long time like pre 1.8 again where there were many releases but none promoted).