Inline editing - performance issues

[andreme]

I was looking at using Immutable records to improve performance and while digging into it I was wondering why the rowDataSelector uses a find instead of the lookup array?

Original

export const rowDataSelector = (state, { griddleKey }) => {
  return state.get('data')
    .find(r => r.get('griddleKey') === griddleKey).toJSON();
};

Updated

export const rowDataSelector = (state, { griddleKey }) => {
  return state.get('data').get(state.getIn(['lookup', griddleKey.toString()])).toJSON();
};

[andreme]

I'm also fairly sure that there is a bug in GRIDDLE_UPDATE_STATE,

const newState = _.omit(action.newState, data);

should be

const newState = _.omit(action.newState, 'data');

?

[ryanlanciaux]

Thanks a ton for looking into this! Everything should be using the lookup where possible so maybe that was something that was missed in the transition.

There very well could be a bug with the _.omit and update state.

[andreme]

I've fixed these things in #729

[andreme]

One reason that Rows and Cells get re-rendered is the use of Immutable.toJSON() in rowDataSelector, rowPropertiesSelector, cellPropertiesSelector. .toJSON() generates a new JS object every time it's called, breaking reacts shallow compare for props.