search

GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 378 forks source link

React 16 #736

Open ryanlanciaux opened 7 years ago

ryanlanciaux commented 7 years ago

Griddle version

1.x

Expected Behavior

Griddle's storybook works with React 16

Actual Behavior

Griddle may be working but may have some things in some of the stories that are using deprecated features (this very well could be Griddle also).

Steps to reproduce

yarn add react@16.0.0-rc.1
yarn add react-dom@16.0.0-rc.1

Pull request with failing test or storybook story with issue

No failing test.

MichaelDeBoey commented 7 years ago

Please update also to recompose ^0.25.1, which supports React ^16.0.0 🙂

MichaelDeBoey commented 7 years ago

@ryanlanciaux Any news on this one? 🙂

dahlbyk commented 7 years ago

https://github.com/GriddleGriddle/Griddle/pull/765/commits/c8b6d16ebd3fcaa71aeac97014a2ce5e0f3d7e4e pinned to typescript@2.5. Apparently there's a fix for v15 (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21233), or we can address this only for v16.

MichaelDeBoey commented 6 years ago

@ryanlanciaux Any news on this one? 🙂

CC: @dahlbyk @joellanciaux

MichaelDeBoey commented 6 years ago

@ryanlanciaux Any news on this one? 🙂

CC: @dahlbyk @joellanciaux

bouzafr commented 6 years ago

Any news? recompose needs to be updated... thanks

ryanlanciaux commented 6 years ago

I hope to address updating some of the dependencies early next week (unless someone beats me to it 👍 ) and would love to have a better strategy for managing them moving forward.

andychongyz commented 6 years ago

Any update?

mDibyo commented 6 years ago

Added a small PR upgrading recompose: https://github.com/GriddleGriddle/Griddle/pull/839