search

GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 378 forks source link

Render Loading component when data is null or undefined #744

Closed dahlbyk closed 7 years ago

dahlbyk commented 7 years ago

Griddle major version

1.x

Changes proposed in this pull request

  1. Providing data of null/undefined no longer blows up with or without LocalPlugin.
  2. When data is null/undefined we now render a Loading component instead of NoResults.

Why these changes are made

User experience can be made less disruptive if the entire Griddle component doesn't need to be replaced by a loading animation (e.g. if a Settings component requires fetching new data).

griddle-loading

Are there tests?

Stories!

ryanlanciaux commented 7 years ago

Awesome! this is super useful 👍