More types for Redux test store - Githubissues

GriddleGriddle / Griddle

Simple Grid Component written in React

http://griddlegriddle.github.io/Griddle/

MIT License

2.5k stars 378 forks source link

More types for Redux test store #778

Closed dahlbyk closed 6 years ago

dahlbyk commented 6 years ago

Griddle major version

1.x

Changes proposed in this pull request

Fix #777

Also, a fix for:

CustomFilterComponent is changing an uncontrolled input of type undefined to be controlled. Input elements should not switch from uncontrolled to controlled (or vice versa). Decide between using a controlled or uncontrolled input element for the lifetime of the component. More info: https://fb.me/react-controlled-components

Why these changes are made

https://github.com/DefinitelyTyped/DefinitelyTyped/pull/21400 broke type inference (or rather, defaulting to any) for our test store connect calls.

Are there tests?

Who needs tests when you have types? :trollface:

ryanlanciaux commented 6 years ago

Thank you! :+1: :+1:

Who needs tests when you have types?

😄