search

GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 378 forks source link

Warning: Component ColumnDefinition declared `PropTypes` instead of `propTypes`. Did you misspell the property assignment? #791

Closed owen8505 closed 6 years ago

owen8505 commented 6 years ago

Griddle version

Expected Behavior

Actual Behavior

Steps to reproduce

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

owen8505 commented 6 years ago

It looks there is a misspelling using ColumnDefinition Component, I always get an Warning: Component ColumnDefinition declaredPropTypesinstead ofpropTypes. Did you misspell the property assignment? error in the console.

crazy4groovy commented 6 years ago

I see this too. Look like line 44: ColumnDefinition.PropTypes = { What did you do to fix this warning?

dahlbyk commented 6 years ago

This is a duplicate of #786, which was fixed by https://github.com/GriddleGriddle/Griddle/commit/d7c058b9c713f7a1621265ed53a8bf128c7763d8 but has not been published yet.

dahlbyk commented 6 years ago

1.11.2 was published this morning with this fix.