GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 378 forks source link

ColumnDefinition expects an object instead of function #799

Closed owen8505 closed 6 years ago

owen8505 commented 6 years ago

Griddle version

1.11.2

Expected Behavior

No console errors

Actual Behavior

After updating Griddle to 1.11.2, I get next console error:

screen shot 2018-02-22 at 14 05 38

Steps to reproduce

My code bellow:

           <ColumnDefinition
                id="riskLevelName"
                title="Risk Index"
                cssClassName="risk-level-name-col"
                headerCssClassName="risk-level-name-head"
                sortMethod={sortByRiskLevel}
                customComponent={props => (
                  <CustomCell
                    {...props}
                    highlight
                    overlayDialog
                    overlayContent={<RiskFactorsDefinition {...props} />}
                  >
                    <RiskLevelName {...props} />
                  </CustomCell>
                )}
              />

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

dahlbyk commented 6 years ago

This is fixed by https://github.com/GriddleGriddle/Griddle/pull/797.