GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 377 forks source link

Release 1.13.0 #808

Closed dahlbyk closed 6 years ago

dahlbyk commented 6 years ago

Trying to ship 1.13.0 with latest changes, but working through an npm issue.

Per recent Gitter conversation, adding a prepare step to build when installed from GitHub. @chrisortman, can you verify this works as expected if you install GriddleGriddle/Griddle#v1.13.0?

chrisortman commented 6 years ago

With yarn 1.5.1 it does not, however I think there may be a bug out there related to this behavior being broken. I am going to test with yarn 1.6.0 and NPM and report back.

chrisortman commented 6 years ago

Using 'GriddleReact/Griddle#1.13.0' as the package identifier:

I think this is the relevant yarn issue https://github.com/yarnpkg/yarn/issues/5235

That yarn issue says that the broken behavior is only triggered with certain formats of package name. I have tested

I then started thinking that maybe yarn would run these scripts when it puts something into its cache, not takes it out, so I did a yarn cache clean and tried installing

After cache clean

An unexpected error occurred: "https://registry.yarnpkg.com/core-js/-/core-js-1.2.7.tgz: EEXIST: file already exists, mkdir '/Users/me/Library/Caches/Yarn/v1/npm-core-js-1.2.7-652294c14651db28fa93bd2d5ff2983a4f08c636/library/fn'".
yarn install  32.91s user 20.18s system 128% cpu 41.457 total

Seems surprising to me the yarn bug has existed for as long as it has

But NPM works so I guess this probably works as good as it is going to for now

dahlbyk commented 6 years ago

@chrisortman thanks!

@joellanciaux @ryanlanciaux @1.3.0 has been published to npm and tagged as next. Not sure how you evaluate fitness to bump latest, so I'll leave that to you.

dahlbyk commented 6 years ago

Well I merged this so #813 could take a dependency on the prepare script, but CodeSandbox doesn't seem to support that yet. Sigh.

Still open to feedback on the script changes.