Open thathenderson opened 6 years ago
thathenderson
commented
6 years ago Tried a few things, but it seems like I can't update react-chartist to solve peer dependency errors in Node 4 and below due to some issues between the webpack:docs task and react-chartist 0.13.1.
Not sure how to proceed with that, but at least it seems to work fine in Node 5+
dahlbyk
commented
6 years ago FWIW, @ryanlanciaux @joellanciaux the Chartist demo on https://griddlegriddle.github.io/v0-docs/customization.html is broken:
TypeError: root is undefined (ChartistGraph.js:177:108) Warning: Each child in an array or iterator should have a unique "key" prop. Check the render method of
OtherPager. See https://fb.me/react-warning-keys for more information. (react.js:19254:9) TypeError: Chartist[type] is not a constructor (ChartistGraph.js:129:26)
ryanlanciaux
commented
6 years ago Ahh - wonder if we should take that out.
dahlbyk
commented
6 years ago Ahh - wonder if we should take that out.
Nobody seems to have noticed, so it doesn't seem worth bending over backward to manage the extra dependency just for docs. 🤷♂️
Note: went ahead and made the react/react-dom 0.14.x and 15.4.x devDependencies changes discussed briefly in #809. I can easily revert that if anyone is uncomfortable with the idea, but then a discussion needs to be had around how to fix
react-addons-test-utilsissues.Griddle major version
0.8.2 (fixes targeted for this version release)
Changes proposed in this pull request
Why these changes are made
To get passing tests!
Are there tests?
No new tests; all existing tests pass (as of this branch)