search

GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 377 forks source link

Fix: Cannot read property 'onSort' of undefined #813

Closed dahlbyk closed 6 years ago

dahlbyk commented 6 years ago

Griddle major version

1.13.0

Changes proposed in this pull request

Reconciles one-line difference between default and local TableHeadingCellContainer, which left the former without access to events.

Since those files are supposed to match as of #749, it seems reasonable to avoid double maintenance. As with TableHeadingCellEnhancer, I've tried to avoid a breaking change for folks who are depending on LocalPlugin exporting components.TableHeadingCellContainer by re-exporting the default component.

Why these changes are made

Fixes #812 (cc @bsalex)

Are there tests?

Storybook no longer breaks. Anyone know if Storybook can be run through CI?

ryanlanciaux commented 6 years ago

This looks good to me! Not sure about storybook through CI -- would be handy almost to be able to run those as cypress tests haha.