GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 377 forks source link

Settings show even when it is "false" #816

Open buildWithSoul opened 6 years ago

buildWithSoul commented 6 years ago

Griddle version

latest version of griddle-react- followed steps listed on site

Expected Behavior

settings should not show, when settings={false} is passed in

Actual Behavior

settings shows regardless of whether boolean is passed in

Steps to reproduce

tested with simple Griddle component and data- settings still shows

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

buildWithSoul commented 6 years ago

Current workaround- passing in style config and set display to none for settings and settingstoggle

dahlbyk commented 6 years ago

Try enableSettings={false}.