Upgrade typescript to ^2.8.0 - Githubissues

GriddleGriddle / Griddle

Simple Grid Component written in React

http://griddlegriddle.github.io/Griddle/

MIT License

2.5k stars 377 forks source link

Upgrade typescript to ^2.8.0 #840

Closed mDibyo closed 5 years ago

mDibyo commented 5 years ago

Griddle major version

v1

Changes proposed in this pull request

Upgrade typescript to ^2.8.0

Why these changes are made

This should hopefully fix error in travis build step npm run check-ts

Error:

node_modules/@types/recompose/index.d.ts(23,47): error TS2304:
Cannot find name 'Exclude'.

Failing builds: https://travis-ci.org/GriddleGriddle/Griddle/builds/441174637 https://travis-ci.org/GriddleGriddle/Griddle/builds/450669719

Reason: The Exclude keyword used in @types/recompose was added in Typescript 2.8 (https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#predefined-conditional-types).

Are there tests?

Successful CI is the test.