search

GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 378 forks source link

Release 1.13.2 - Griddle now fully compatible with React 16 #842

Open mDibyo opened 5 years ago

mDibyo commented 5 years ago

Griddle major version

v1

Changes in this release

mDibyo commented 5 years ago

@ryanlanciaux and other maintainers: I was able to get master installed by doing yarn add https://github.com/GriddleGriddle/Griddle.git#49306e7, but would be nice to just have a new package version. :)

UPDATE: A quirk with yarn prevents yarn add from being a feasible approach. yarn add runs the prepare script, but running yarn install for a project depending on the package does not, meaning this approach doesn't work in any deployment environments.

mDibyo commented 5 years ago

Also, I had missed updating yarn.lock in #839 and #840, and this PR fixes that. (I can create a separate PR for fixing yarn.lock, if you guys would prefer that. )

mDibyo commented 5 years ago

@ryanlanciaux @dahlbyk would be super duper nice to get this new version of the package. :) Anything I can do to help with this?

Our team is currently blocked on upgrading to React 16, since the current version of Griddle (v1.13.1) is not "officially" compatible with React 16. But that issue was resolved when #839 was merged. All we need now is a new version of the package, and we'd rather not depend on a private fork of the package.

JamesNimlos commented 5 years ago

If using yarn, you can use the package.json#resolutions property to force the nested version resolution. In this case we added the following to our package.json file:

{
  "resolutions": {
    "griddle-react/recompose": "^0.25.1"
  }
}
docrinehart commented 5 years ago

Referencing #856

docrinehart commented 5 years ago

@ryanlanciaux This PR is invalidated by #849 , we should be able to close this with the next release.

LoganArnett commented 5 years ago

Any word on when this will be released?

Plummat commented 5 years ago

bump

beekerstudios commented 4 years ago

Anyway this can get merged so people can upgrade to react 16.x, this is the only thing holding it up it looks like.