GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 377 forks source link

import lodash functions instead of whole lib #857

Closed lvaldovinos closed 5 years ago

lvaldovinos commented 5 years ago

Griddle major version

1.x

Changes proposed in this pull request

Import lodash functions that are used in code, instead of whole lodash lib.

Why these changes are made

854 was created and requested by @ryanlanciaux

Are there tests?

No, existing tests weren't changed.

lvaldovinos commented 5 years ago

@ryanlanciaux @docrinehart endsWith problem is related to reducer object has extra symbol property (not sure if this symbol property is added by webpack), so when it's passed to buildGriddleReducer it throws error, I've fixed it by making sure all keys provided in reducerObject are indeed string, hope it's okay.

ryanlanciaux commented 5 years ago

Will do a little more testing on this and get an alpha release out for folks to try (followed by an actual release) Thanks again @lvaldovinos 🚀 this is great.

docrinehart commented 5 years ago

Fixes #854