GriddleGriddle / Griddle

Simple Grid Component written in React
http://griddlegriddle.github.io/Griddle/
MIT License
2.5k stars 377 forks source link

`customComponent` of type `object` supplied to `ColumnDefinition`, expected `function`. in ColumnDefinition in new griddle-react #864

Open mkotar opened 4 years ago

mkotar commented 4 years ago

Griddle version

"griddle-react": "1.13.1", but tested also on "1.13.0" "react-redux": "^7.2.0",

Actual Behavior

Failed prop type: Invalid prop customComponent of type object supplied to ColumnDefinition, expected function. in ColumnDefinition

Any idea how to fix it ? Code is basically copied from documentation and still getting this error

Steps to reproduce

<ColumnDefinition id="serialNumber"
                                                         title={translate('recorders.serialNumber')}
                                                          customComponent={enhancedWithRowData(this.getRecorderSerialNumber)}
                                                          width={50}/>

and

private getRecorderSerialNumber = ({rowData}) => {
        return (
            <div className={style.link}>
                <Link to={`/recorders/${rowData.id}/view`}>{rowData.serialNumber}</Link>
            </div>
        );
    };
        enhancedWithRowData: connect((internalState: any, props: any) => {
            return {
                rowData: rowDataSelector(internalState, props)
            };
        }),
export const rowDataSelector = (state: any, params: any) => {
    return state
        .get('data')
        .find(rowMap => rowMap.get('griddleKey') === params.griddleKey)
        .toJSON();
}
aaronsmulktis commented 3 years ago

👆 Same versions for me, same issue for me.

This is a great package btw, been using it for years, so thank you. Guess this is just the first time I'm diving deep enough to want custom rowData.