search

GriddleGriddle / griddle-core

Core grid logic for Griddle
5 stars 9 forks source link

Make a dist build webpack.config #20

Closed ryanlanciaux closed 9 years ago

ryanlanciaux commented 9 years ago

Currently the webpack config for dev/dist is all in one file with branching logic to determine how the configuration should be built and exported. I'm proposing that we be kind of lame and break this apart into two separate config files. A couple of the reasons -- it should be easier to maintain down the road -- the configuration settings have 'some' similarities but are also quite different. Additionally, I would like to have everything running as npm scripts rather than grunt/gulp/whatever if possible (the docs project will likely remain in grunt -- this is going to be separate from the source so no big deal). We could write a script that sets the environment variables and calls webpack but that also seems overkill as opposed to 'dist': 'webpack --config dist.config.js'.

It's possible I'm not thinking everything through which is why I'm labeling this as question initially :)

ryanlanciaux commented 9 years ago

https://github.com/GriddleGriddle/griddle-core/pull/22/files - Just went ahead and made the change. Please let me of any thoughts on this and I'll merge or close it :)