search

GriefPrevention / GriefPrevention

The official self-service anti-griefing Bukkit plugin for Minecraft servers since 2011.
https://griefprevention.com
GNU General Public License v3.0
296 stars 238 forks source link

Plant tree bug #2318

Open caiobarnes opened 4 months ago

caiobarnes commented 4 months ago

Observed Behavior

It's in the video -> https://youtu.be/0b5WYWfYDdI

Expected Behavior

It's in the video -> https://youtu.be/0b5WYWfYDdI

Reproduction steps

It's in the video -> https://youtu.be/0b5WYWfYDdI

Stack trace or error log

None

Server version

Current: git-Purpur-2176 (MC: 1.20.4)*

GriefPrevention version

GriefPrevention version 16.18.3

Configuration

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/

GriefPrevention:
  SeaLevelOverrides:
    world: -1
    world_nether: -1
  Claims:
    Mode:
      world: Survival
      world_nether: Survival
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: true
    LockTrapDoors: true
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    RaidTriggersRequireBuildTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 500
    Claim Blocks Accrued Per Hour:
      Default: 50
    Max Accrued Claim Blocks:
      Default: 1000000000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 4
    AutomaticNewPlayerClaimsRadiusMinimum: 0
    ExtendIntoGroundDistance: 1215752192
    MinimumWidth: 5
    MinimumArea: 50
    MaximumDepth: -2147483648
    InvestigationTool: STICK
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 30
      UnusedClaimDays: 60
      AllClaims:
        DaysInactive: 60
        ExceptWhenOwnerHasTotalClaimBlocks: 10000000
        ExceptWhenOwnerHasBonusClaimBlocks: 10000000
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: false
    LoginCooldownSeconds: 60
    LoginLogoutNotificationsPerMinute: 0
    ChatSlashCommands: /me;/global;/local
    WhisperSlashCommands: /tell;/pm;/r;/whisper;/msg
    WarningMessage: Please reduce your noise level.  Spammers will be banned.
    BanOffenders: false
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 120
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      world: false
      world_nether: true
    ProtectFreshSpawns: true
    PunishLogout: false
    CombatTimeoutSeconds: 25
    AllowCombatItemDrop: false
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: true
      AdministrativeClaims: true
      AdministrativeSubdivisions: true
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: true
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: false
  Economy:
    ClaimBlocksMaxBonus: 0
    ClaimBlocksPurchaseCost: 0.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: false
    NonPvPWorlds: false
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: false
  BlockSurfaceOtherExplosions: true
  LimitSkyTrees: true
  LimitTreeGrowth: false
  PistonMovement: CLAIMS_ONLY
  PistonExplosionSound: true
  FireSpreads: false
  FireDestroys: false
  AdminsGetWhispers: true
  AdminsGetSignNotifications: true
  VisualizationAntiCheatCompatMode: false
  SmartBan: true
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 10
  SilenceBans: true
  Siege:
    Worlds: []
    BreakableBlocks:
    - GRASS_BLOCK
    - DIRT
    - COBBLESTONE
    - OAK_PLANKS
    - SPRUCE_PLANKS
    - BIRCH_PLANKS
    - JUNGLE_PLANKS
    - ACACIA_PLANKS
    - DARK_OAK_PLANKS
    - SAND
    - GRAVEL
    - GLASS
    - GRASS     <-- can't understand this entry, see BukkitDev documentation
    - FERN
    - DEAD_BUSH
    - WHITE_WOOL
    - ORANGE_WOOL
    - MAGENTA_WOOL
    - LIGHT_BLUE_WOOL
    - YELLOW_WOOL
    - LIME_WOOL
    - PINK_WOOL
    - GRAY_WOOL
    - LIGHT_GRAY_WOOL
    - CYAN_WOOL
    - PURPLE_WOOL
    - BLUE_WOOL
    - BROWN_WOOL
    - GREEN_WOOL
    - RED_WOOL
    - BLACK_WOOL
    - SNOW
    - GLASS_PANE
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: false
  SilverfishBreakBlocks: false
  CreaturesTrampleCrops: false
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: false
  MobProjectilesChangeBlocks: false
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: true
      Administrative Activity: false
      Debug: false
      Muted Chat Messages: false
  ConfigVersion: 1

Plugin list

Only one GriefPrevention

Running without GriefPrevention

Running with only GriefPrevention

Running on a fresh, clean server installation

Using unmodified client

We appreciate you taking the time to fill out a bug report!

bigpresh commented 4 months ago

It's not clear from the video if the location the tree sapling doesn't stay is a protuding dirt ledge, but I suspect that it is, and that the tree is being blocked by the LimitSkyTrees feature - see the docs: https://docs.griefprevention.com/configuration/#preventing-tree-grief

caiobarnes commented 4 months ago

It's not clear from the video if the location the tree sapling doesn't stay is a protuding dirt ledge, but I suspect that it is, and that the tree is being blocked by the LimitSkyTrees feature - see the docs: https://docs.griefprevention.com/configuration/#preventing-tree-grief

Good afternoon, I read it. However, my setting is set to true. And yet you can do it

QarthO commented 4 months ago

Well you're supposed to set it to false not true.

bigpresh commented 4 months ago

Yeah - if LimitSkyTrees is set to true, then GP will cancel any sapling planting on dirt blocks without a suitable amount of blocks underneath. If you don't want that behaviour, and want people to be able to plant saplings on any dirt block, then you need to set it to a false value, as @QarthO said.

caiobarnes commented 4 months ago

Yeah - if LimitSkyTrees is set to true, then GP will cancel any sapling planting on dirt blocks without a suitable amount of blocks underneath. If you don't want that behaviour, and want people to be able to plant saplings on any dirt block, then you need to set it to a false value, as @QarthO said.

Yes, but the problem is that it is not working correctly, as you can see in the video

Jikoo commented 4 months ago

Re: the first half of the video, trying to place the sapling: The area you are initially trying to place the sapling and being blocked appears to be a very slim layer of grass and dirt, though we can't see for sure from the angle you're at. You cannot place the sapling because LimitSkyTrees is true, as everyone else has said before. If you believe this is not correct, you will need to provide better views of the area where you are trying to place the sapling.

Re: tree growing into claim: The tree can grow into the claim because LimitTreeGrowth is set to false.

Re: bonemealing grass: This was fixed in 404c5684856bce9bb6dc62bb575e6760265b0f01 for v17.