search

Griefed / ServerPackCreator

Create a server pack from a Minecraft Forge, NeoForge, Fabric, LegacyFabric or Quilt modpack!
https://serverpackcreator.de
GNU Lesser General Public License v2.1
187 stars 10 forks source link

[Improvement Ask]: Add ability to create pack without run scripts and jvm arguments. #488

Closed Ianthasys closed 9 months ago

Ianthasys commented 9 months ago

Whats the improvement you would like to be made?

Personally, I use the pack creator to remove client-side dependencies when I update whatever modpack I'm running on my server. It would be nice to be able to have the creator skip making run scripts and java args file, as I'm just reusing the ones created by the docker container I'm already using for the pack. (the ones created by the docker container don't have the same naming scheme as the ones made by SPC, so they just take up extra space on the drive.) As of currently, I just delete them myself after unzipping, but it'd be nice if they weren't created in the first place as it's less data to upload to the server over ssh.

Anything else you would like to add?

Tell me!

Code of Conduct

Griefed commented 9 months ago

Heyo, the main goal of ServerPackCreator is to create ready-to-use server packs. As such, start scripts and variables.txt are always created.

You've mentioned yourself that you simply delete these files. I recommed continuing to do so. Implementing the option to not create those would be much more work for me, compared to you simply deleting these files. Plus, I just know users would disable the creation of these files by accident, only to then come running to me yelling "buuuug buuuuuug ur sophtwär dusnt wörk!" 😂

Griefed commented 9 months ago

Additionally

it's less data to upload to the server over ssh.

They're very small textfiles. If you worry about a couple of Kb's of data, you have much bigger problems at hand than my script- and variables-files. It's hardly worth mentioning.

Ianthasys commented 9 months ago

it's not like it was an urgent thing. as I said, I just delete them myself. it'd be nice to be able to not have them created in the first place though. given that there's a checkbox to include server icon and properties, I figured it wouldn't be a bad idea to have a fourth box that left out the run scripts. image

Ianthasys commented 9 months ago

Given that you said it'd be much more work than necessary, I'll close the issue though.

Griefed commented 9 months ago

Aye, it'd be much more work compared to rm file, in addition to the fact that the vast majority of people generate server packs for distribution on platforms like CurseForge or Modrinth, where the people who download these packs simply want to run the script and be done with it.

I appreciate the fact that you took the time to create this issue, but I have to decline this one.

Take care o7