Griefed / ServerPackCreator

Create a server pack from a Minecraft Forge, NeoForge, Fabric, LegacyFabric or Quilt modpack!
https://serverpackcreator.de
GNU Lesser General Public License v2.1
187 stars 10 forks source link

[Improvement Ask]: "True" Portable #508

Closed DivannKokos closed 7 months ago

DivannKokos commented 7 months ago

Whats the improvement you would like to be made?

Right now, portable version (at least in last stable release version), store its files in %username%/ServerPackCreator. Portable supposed to be, well, portable, and to not store files in system outside of a folder in which it is contained. Better to store files in folder where the serverpackcreator.exe is.

Anything else you would like to add?

Required:

Using the JAR-file release requires Java 21.
Working internet connection recommended.

The installers ship their own Java installations.

ATTENTION: I can not and will not guarantee that ServerPackCreator will work flawlessly with any other Java version other than version 17.

requires 21, but you guarantee 17 is a bit strange, presume you forgor to change 17 to 21 here

Code of Conduct

Griefed commented 7 months ago

Heya DivannKokos,

whilst I understand this request, be aware that Portable Applications, or at least what definitions of it are available, do not enforce storing related files in the same directory of the executable. See https://en.wikipedia.org/wiki/Portable_application

In the case of ServerPackCreator, the portable bit relates to having a portable executable to run SPC, withour requiring the installation of a separate Java runtime. As such, there is no "True" portable.

A portable application (portable app), sometimes also called standalone, is a program designed to operate without changing other files or requiring other software to be installed. In this way, it can be easily added to, run, and removed from any compatible computer without setup or side-effects.[1]

In practical terms, a portable application often stores user-created data and configuration settings in the same directory it resides in. This makes it easier to transfer the program with the user's preferences and data between different computers. A program that doesn't have any configuration options can also be a portable application.

Especially the following part:

In practical terms, a portable application often stores user-created data and configuration settings in the same directory it resides in.

You have the option to change the home-directory of ServerPackCreator if you so desire. The settings for that can be found in the GUI version, under Settings -> Global -> Home directory.

Because ServerPackCreator is designed to run on multiple different platforms and in mutliple different ways, it is easier for me to handle it that way and let users handle their home-directory, if they so desire. Most people are comfortable with the default, that being the users home-directory.

I will have to decline this Improvement Ask.

Cheers, Griefed

P.S.: Yep, you're right, the Java 17 bit is an oversight I missed when I migrated to Java 21. :) Thanks for the catch!

DivannKokos commented 7 months ago

i just downloaded the last alpha, and it already has this behaviour that i wanted, should've do this before writing hah