sachet-mittal
commented
6 years ago Sure. Will take care of it in next pull request. Don't want to take it up in this one.
FWIW, I don't think worrying about python 2 and 3 compatibility is an issue that should be a point of concern.
Reference: https://docs.python.org/2/howto/pyporting.html#the-short-explanation
On Mon, Oct 9, 2017 at 8:55 AM, Ankit Singh notifications@github.com wrote:
@Griffintaur commented on this pull request.
In Main.py https://github.com/Griffintaur/News-At-Command-Line/pull/19#discussion_r143380478 :
sys.exit()
- if (newsSourceNumber >=len(newsSources)):
- print ("Please select the index no less than "+ str(len(newsSources)))
I think it is is better to go with 'from future import print_function' at this point in time.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Griffintaur/News-At-Command-Line/pull/19#discussion_r143380478, or mute the thread https://github.com/notifications/unsubscribe-auth/AHZWMeHmcsP9mrcDp19ywXk8sC1TsSwLks5sqZJDgaJpZM4PtFa9 .
$ flake8 *.py ExtractMainContent.py:34:80: E501 line too long (144 > 79 characters) ExtractMainContent.py:48:80: E501 line too long (90 > 79 characters) ExtractMainContent.py:50:80: E501 line too long (90 > 79 characters) ExtractMainContent.py:52:80: E501 line too long (97 > 79 characters) ExtractMainContent.py:55:80: E501 line too long (131 > 79 characters) ExtractMainContent.py:57:80: E501 line too long (101 > 79 characters) Extractor.py:87:80: E501 line too long (84 > 79 characters) Main.py:40:80: E501 line too long (120 > 79 characters) Main.py:59:80: E501 line too long (89 > 79 characters) NewsPulling.py:15:80: E501 line too long (94 > 79 characters) NewsPulling.py:31:80: E501 line too long (113 > 79 characters)