search

Griffintaur / News-At-Command-Line

:newspaper: News at the command line
MIT License
47 stars 53 forks source link

[Enhancement] Migrate to Python3 ? #26

Open ctrlsam opened 6 years ago

ctrlsam commented 6 years ago

This would be great in Python 3, I think this would be appreciated.

Griffintaur commented 6 years ago

cool. Go ahead

ctrlsam commented 6 years ago

@Griffintaur I have submitted a PR, do you think you can take a look at it, thanks

ctrlsam commented 6 years ago

@Griffintaur depending on what you want, you might want to think about having the Python 2.7 version in a separate branch for those that don't use Python 3.

TomFaulkner commented 6 years ago

Is this going to get merged? I noticed there are several unmerged PRs and master hasn't been updated in months.

ctrlsam commented 6 years ago

I know right, this is a little frustrating. If it is not merged after a week I'll make a separate repo.

TomFaulkner commented 6 years ago

I was thinking of doing the same.

Aside from Python 3, I saw you did some cleanup, did you do anything with filenames and pathing?

On Sun, Feb 18, 2018, 6:44 PM Sam Redmond notifications@github.com wrote:

I know right, this is a little frustrating. If it is not merged after a week I'll make a separate repo.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Griffintaur/News-At-Command-Line/issues/26#issuecomment-366564004, or mute the thread https://github.com/notifications/unsubscribe-auth/AOQ4TL757EEjziSg7dh05qFYMOnehBZGks5tWMPzgaJpZM4R4dgt .

ctrlsam commented 6 years ago

@TomFaulkner I have not changed file names/paths. If it helps, you can fork my copy: https://github.com/SillySam/News-At-Command-Line

I will be happy to contribute to your copy as this guy doesn't seem to active.

PS: I am just about to make another change on my fork that removes the owner's file headers and email, etc.

ctrlsam commented 6 years ago

@TomFaulkner I also want to note, when you make your own copy, please make your API key as I don't think the owner would like the key going viral :D

TomFaulkner commented 6 years ago

Yeah, that is what I had in mind. Since moving to Python 3, without maintaining 2.7 compatibility is a breaking change, I think it would be a good time to make other breaking changes for PEP8 and a more pythonic ways of doing things.

TomFaulkner commented 6 years ago

Posted this as a PR on @SillySam's fork. But, thought I would mention it here. I have a more Pythonic fork from @SillySam's fork. I cleaned up quite a bit, more still needs done, but it's posted at least. I plan to do more as I get time.

https://github.com/TomFaulkner/News-At-Command-Line

TomFaulkner commented 6 years ago

Since this was merged, I moved discussion to #30 so this issue can be closed.