GrigorisParaskevakos
commented
7 years ago Hello and thank you for your comments, I followed your advices from your feedback and I uploaded a corrected version of the same project https://github.com/GrigorisParaskevakos/prj-rev-bwfs-dasmoto
Grade: Satisfactory
Great job on this project! It looks close to the spec and your code shows a solid understanding of this week’s concepts. An area for improvement would be: Add comments to orient yourself and other readers within the code. Make price a class not an id. Use & to escape an ampersand, in both the h1 and the title. This explains why: https://stackoverflow.com/questions/14765766/when-i-need-to-escape-html-string
Your folder structure should change to have a folder called images inside resources. Put all images inside images and change filepaths accordingly. See these resources for more info:
http://www.coffeecup.com/help/articles/absolute-vs-relative-pathslinks/ and https://css-tricks.com/quick-reminder-about-file-paths/
As an added challenge, make 3 parent divs for the 3 sections, and put the class named “item” on them all. Then in css, make some styling for that class to add padding, margins, maybe text centering. Experiment with margin:0 auto and specifying a max-width on the class. Here is a quick resource on centering in css https://css-tricks.com/centering-css-complete-guide/
Keep up the good work!