GrimAnticheat / Grim

Fully async, multithreaded, predictive, open source, 3.01 reach, 1.005 timer, 0.01% speed, 99.99% antikb, "bypassable" 1.8-1.20 anticheat.
GNU General Public License v3.0
1.06k stars 296 forks source link

FabricatedPlace/PositionPlace [OptiFine 1.12.2] #1365

Open ManInMyVan opened 6 months ago

ManInMyVan commented 6 months ago

Describe the false positive and how to replicate it

Client: OptiFine 1.12.2 G6 pre1

RightClick on TallGrass. DoubleTallGrass is easier to flag, but normal TallGrass is flaggable

Grim version

60f503da with some changes to BadPacketsL

Server version

Paper 1.12.2

Plugins

ViaVersion 4.9.2 ViaBackwards 4.9.1 ViaRewind 3.0.5

z7087 commented 6 months ago

I think some of the hitbox data for blocks like tall grass is wrong (in legacy versions?)

ManInMyVan commented 6 months ago

I think some of the hitbox data for blocks like tall grass is wrong (in legacy versions?)

I tested it on vanilla and it didn't false (which is why the title says optifine) Actually I think you're right, (on vanilla 1.8.9) if you click in the corner of a block like glass panes (while in it) it flags

z7087 commented 6 months ago

I think I was wrong, before now I had optifine installed in the client I was using for testing and I never realized optifine changes the vanilla hitboxes

SamB440 commented 6 months ago

Well go tell Optifine to fix their client then. It's ridiculous how much Optifine breaks vanilla behaviour (see: fastmath...)

Cuteistfox commented 5 months ago

I think I was wrong, before now I had optifine installed in the client I was using for testing and I never realized optifine changes the vanilla hitboxes

Well then isnt this a optifine issue instead of grim issue?

ManInMyVan commented 5 months ago

I think I was wrong, before now I had optifine installed in the client I was using for testing and I never realized optifine changes the vanilla hitboxes

Well then isnt this a optifine issue instead of grim issue?

Looks like someone has reported a similar bug to optifine https://github.com/sp614x/optifine/issues/7028, but it's been ~1.6 years and (tmk) has not been discussed at all since.