GrimAnticheat / Grim

Fully async, multithreaded, predictive, open source, 3.01 reach, 1.005 timer, 0.01% speed, 99.99% antikb, "bypassable" 1.8-1.20 anticheat.

GNU General Public License v3.0

1.11k stars 329 forks source link

Basic interact check #1391

Open SkirmisLTU opened 8 months ago

SkirmisLTU commented 8 months ago

Feature description

The Suggestion

Hello, I would like to suggest adding an interaction check to Grim because currently, there is none. At the moment, the most needed check is to detect if a player is interacting with chests behind a wall or attacking another player behind a block (this is especially common for cheaters who use cheats to attack through cobwebs on certain PvP servers).

Why It Fits Grim Anticheat?

I believe that it would be possible to create a check that is mathematically impossible to bypass since it would only need to trace where the player was looking, and if there are any blocks between the player who is interacting and the object that the player is trying to interact with. I think that a check like this would fit Grim's "philosophy" perfectly.

I know that this shouldn't be really hard for all the talented creators and contributors of Grim anticheat ;) Thanks.

ManInMyVan commented 8 months ago

So basically #1238 and #951?

SkirmisLTU commented 8 months ago

These suggestions aren't exactly the same as mine, but they're pretty similar. I see that there was some solutions, but I don't understand why they were abandoned and not implemented...

SamB440 commented 8 months ago

1238 is still a draft because noone else has been testing it and I don't like the implementation of handling uncertain block changes

SkirmisLTU commented 8 months ago

@SamB440, can I get the latest jar Grim with implementation of your code? I have medium sized server, where I can test it on my production environment and report if there is any issues with it. Thanks

Symmettry commented 8 months ago

Well, just make it cancel the interaction and don't ban them.

SkirmisLTU commented 8 months ago

Well, just make it cancel the interaction and don't ban them.

I have no idea why are you saying me this, but I am still waiting for @SamB440 to get me the jar so I can begin testing

SamB440 commented 8 months ago

Updated: https://github.com/SamB440/Grim/actions/runs/8308823011/artifacts/1332000061

SkirmisLTU commented 7 months ago

Hello again @SamB440, I've been using your version (with reach check for hitting trough walls) for more than a month now on my server (50-100 active players daily, PVP focused server). I ran into 0 problems. I think that it's safe to merge this update into main branch. Or maybe I can get update version of it?

SamB440 commented 7 months ago

Done. https://github.com/SamB440/Grim/actions/runs/8815892204/artifacts/1442987269

SkirmisLTU commented 5 months ago

Hi one more time @SamB440,

I think it's time to merge this check. I've been using it for a long time now and haven't had any issues. My server has up to 100-200 players daily, so I believe that if there were any issues with this check, they would have shown by now. In case there is an issue with it, I suggest making a configuration option (such as check-through-blocks: True) so it can be disabled and not cause any problems.

If you're still not convinced, could I get an updated jar file?

Symmettry commented 5 months ago

Well, just make it cancel the interaction and don't ban them.

I have no idea why are you saying me this, but I am still waiting for @SamB440 to get me the jar so I can begin testing

uh i didn't reply to u, i commented on the thread. it probably notifies everyone

SamB440 commented 5 months ago

Alright I shall clean it up and merge at some point

SkirmisLTU commented 5 months ago

Hi again @SamB440,

Do you have any news? I can't see the check being added anywhere. If you're not going to add it right now, could I ask you for a new jar with this check?

SamB440 commented 5 months ago

I've been busy so haven't had much time, will do later

SkirmisLTU commented 5 months ago

Any updates?

SamB440 commented 5 months ago

https://github.com/SamB440/Grim/actions/runs/9725696052/artifacts/1651545226

SkirmisLTU commented 4 months ago

Hi @SamB440, just a heads up that I'm still waiting for this to be merged to main branch;)

SkirmisLTU commented 3 months ago

Any news @SamB440 ?

Axionize commented 3 months ago

I've taken to maintaining a temporary fork with all the other latest GrimAC changes with Sam's reach and hitting through wall checks.

You can download the jars from releases here: https://github.com/Axionize/Grim/releases

I'll be working on improving the performance of the checks. Please report any issues.

SkirmisLTU commented 2 months ago

Got no issues so far. I it would be nice if it could be updated or merged into main branch. @Axionize @SamB440