Don't shade packetevents anymore

GrimAnticheat / Grim

Fully async, multithreaded, predictive, open source, 3.01 reach, 1.005 timer, 0.01% speed, 99.99% antikb, "bypassable" 1.8-1.20 anticheat.

GNU General Public License v3.0

1.1k stars 326 forks source link

Don't shade packetevents anymore #1528

Open ghost opened 5 months ago

ghost commented 5 months ago

Feature description

Pros of unshaded packetevents:

Increased performance, multiple plugins using packet events can share the same instance.
Allows server owners to update packet events without waiting on grim to do it.
Halves grims jar size
Seperation of concerns
@retrooper gets credit for his work (Downloads for shaded packet events aren't counted, if unshaded he gets downloads/recognition/ad revenue)

Cons:

Server owners need to download 2 jars, one for packet events one for grim

SamB440 commented 5 months ago

No, we need control over the listener priorities and to have our own encoder/decoder, you will get conflicts with other plugins otherwise

ghost commented 5 months ago

No, we need control over the listener priorities and to have our own encoder/decoder, you will get conflicts with other plugins otherwise

I don't understand, you shade packet events directly from the github repo, all you do is relocate it?

SamB440 commented 5 months ago

Shading packetevents gives Grim its own encoder/decoder, this also means we don't have any plugins interfering in packet listener priorities, and any plugins that mess with packets using packetevents (such as spawning entities) will go through Grim.

ghost commented 5 months ago

Shading packetevents gives Grim its own encoder/decoder, this also means we don't have any plugins interfering in packet listener priorities, and any plugins that mess with packets using packetevents (such as spawning entities) will go through Grim.

Seems like a non issue, why would plugin be messing with spawning entity packets? Grim doesnt modify any packets right? just reading? For packets we are receiving grim should listen at lowest priority, for packets being sent listen at highest, simple no?

SamB440 commented 5 months ago

No, I suggest you look at all the different priorities Grim is using. I have packet-level NPC plugins, if Grim was not shaded then my packets might not be read by Grim, and other plugins may listen at different packet priorities and modify packets.

AoElite commented 5 months ago

@IssueDescription Retrooper is fine with people shading packetevents & he isn't getting ad revenue anyways.

retrooper commented 5 months ago

Modrinth does offer a little ad-revenue. At the end of the day, not shading benefits the users so it has little to do with me.