ClangTidy: unused vars fixes

GrimSqueaker / remc2

Recode Binary code of game Magic Carpet2 to C/C++ language(remake MC2 for any platform)

6 stars 0 forks source link

ClangTidy: unused vars fixes #58

Closed GrimSqueaker closed 3 years ago

GrimSqueaker commented 3 years ago

Now based on Linux 32 bit

turican0 commented 3 years ago

I mean this change is wrong: void dbgfprintf(FILE file, const char format, ...) { //void dbgfprintf(FILE file,char str) { **- fprintf(file, format);

fprintf(file, "%s", format);** fprintf(file, "\n"); }

"format" is formated input for fprintf, not only string. Tom.

GrimSqueaker commented 3 years ago

I can change this back and then merge the branch. But actually, if it is formatted input, it has to be a string. The variadic input "..." is not passed on to fprintf. So Clang tidy is not wrong in this case.