Grimmys / rpg_tactical_fantasy_game

A tactical turn-based game project in pygame, open to support
GNU General Public License v3.0
405 stars 85 forks source link

Move->Trade->Cancel->Move Again #17

Closed BadaroThiago closed 1 year ago

BadaroThiago commented 3 years ago

It is possible to move a character to a position next to an ally, initiate a trade, trade itens/money, cancel menu and that character is returned to his initial position, but the trade is already done and he can move again. I suggest that after trades, the player loses the ability to cancel the menu until character has attacked or choose to wait.

Grimmys commented 3 years ago

I was already aware of this issue, the problem is not that easy to correct. I think it should be possible to cancel trade when it has only been initiated.

Anyway, I think about it, I have other priorities for the moment but thank you for creating this issue. 👍

DurimDelilaj commented 1 year ago

Rip

JimZhouZZY commented 1 year ago

It seems that I cannot reproduce the bug on trading items. #37 Fixed the bug well. But I did reproduced it when sending gold. (See the video) https://github.com/Grimmys/rpg_tactical_fantasy_game/assets/140597003/181f4479-9f48-442d-a937-45723ca2e890 Ill try work for it.

Grimmys commented 1 year ago

Thanks for investigating and fixing the issue @JimZhouZZY

Closing it as fixed by #65