search

Grimmys / rpg_tactical_fantasy_game

A tactical turn-based game project in pygame, open to support
GNU General Public License v3.0
405 stars 85 forks source link

added walking and attacking sfx #22

Closed beibarys98 closed 3 years ago

beibarys98 commented 3 years ago

gitignore does not seem to work. i tried some things, but unsuccessful.

Grimmys commented 3 years ago

Very interesting sound effects and background music, you did a great job, thanks!

I will try to remove the useless files (venv + ipynb_checkpoints).

I'm also not a big fan of the comments you added before your statements, I don't think it's really useful and maintenable... (git keeps track of ownership of each contributor through access to commit history) So if you agree I will probably remove them too, and I will add a line in the CREDITS file to precise that sound effects and their integration into the game have been made by you! (However, if you took sound effects from some open source project it's ok too, I would just like to know who should be credited)

beibarys98 commented 3 years ago

sound effects are from random places of the internet. youtube, websites. but one person who deserves credit is soundtrack composer. i took it from youtube and converted it to 8 bit music. it holds no copyright, so it is free. Kevin Macleod made it. https://www.youtube.com/user/kmmusic

and yes, do whatever you like, remove and so on. i just want to help you.

Grimmys commented 3 years ago

Nice thanks!

Do you still have the direct link to the original soundtrack please ? It's just to made a proper attribution to the artist, if you don't have it it's ok.

beibarys98 commented 3 years ago

https://www.youtube.com/watch?v=eZ_r1H9vHkI&ab_channel=AlwaysMusic

this is the music