search

Grimmys / rpg_tactical_fantasy_game

A tactical turn-based game project in pygame, open to support
GNU General Public License v3.0
394 stars 85 forks source link

fixed trade -> cancel bug #36

Closed beibarys98 closed 3 years ago

beibarys98 commented 3 years ago

when you right_click, items you traded goes back to the owner and are removed from the receiver

Grimmys commented 3 years ago

I will test your code tomorrow, but I'm not sure it's totally right...

Like if you cancel the movement of the active character after a trade, items that this character earned from trade go back to original owner, good. But what if the active player sent an item to another character... I'm not sure that this other character will loose the item after cancelling.

Grimmys commented 3 years ago

Ok I tried your code and there seems to be only one bug.

Like I said, if the active character send an item to another one, this another character would keep the item after cancelling.

Exact situation :

Select character A -> Make a trade with character B -> A send an item to B -> Cancel turn -> Both characters will have the item

beibarys98 commented 3 years ago

ok. started working on a fix where it would return to the selected player if he gives items. today or tomorrow must be ready.