Grimmys / rpg_tactical_fantasy_game

A tactical turn-based game project in pygame, open to support

GNU General Public License v3.0

392 stars 85 forks source link

Adding python3.9 environment requirement in README.md #61

Closed JimZhouZZY closed 11 months ago

JimZhouZZY commented 11 months ago

60

Grimmys commented 11 months ago

Yes, good catch.

I thought adding the from __future__ import annotations line would be enough to be backward-compatible with 3.8 (and maybe 3.7?) but looks like it's not covering all the cases and I probably didn't tested it correctly at this time...

Anyway, I guess you are right, it may be better to drop support of Python 3.8, it's going to be a dead version in one year anyway: https://devguide.python.org/versions/

Grimmys commented 11 months ago

I'm going to squash and merge this PR because I can see the commit history is a bit messy 😅

I.e. it means that all these commits are going to be simplified into a single one.

JimZhouZZY commented 11 months ago

Thank you for your check and reply : ). I'm glad I could be of a little help.