search

Grimmys / rpg_tactical_fantasy_game

A tactical turn-based game project in pygame, open to support
GNU General Public License v3.0
405 stars 85 forks source link

#32 Save reminder #62

Closed JimZhouZZY closed 1 year ago

JimZhouZZY commented 1 year ago

Add a save reminder inviting people to save the game every next level. The reminder looks like this: Reminder It appears at very the beginning of next level, except level0 (no saving needed). If "Yes" button pressed, the reminder will close and call the function open_save_menu. If "No" button pressed, the reminder will close without doing anything else.

Grimmys commented 1 year ago

Looks great!

I was able to find only one minor issue: if you do accept to save, and then leave the game, when you come back, it's not going to trigger the pre-placement events. In other terms, you are not going to see the text that is shown at the really beginning of the level, because the save system was done assuming it was not possible to save before reaching these events. However, the post-placement events, and all events triggered at later time are still going to be triggered.

This issue is so minor I think we could just disregard it for now. But a way to fix it could be to store a value in the save that would indicate that the save was done at the really beginning of the level, and then check this value at loading time to determine if the events should be triggered or not.

JimZhouZZY commented 1 year ago

Looks great!

I was able to find only one minor issue: if you do accept to save, and then leave the game, when you come back, it's not going to trigger the pre-placement events. In other terms, you are not going to see the text that is shown at the really beginning of the level, because the save system was done assuming it was not possible to save before reaching these events. However, the post-placement events, and all events triggered at later time are still going to be triggered.

This issue is so minor I think we could just disregard it for now. But a way to fix it could be to store a value in the save that would indicate that the save was done at the really beginning of the level, and then check this value at loading time to determine if the events should be triggered or not.

Understand, modfiying