search

Grimmys / rpg_tactical_fantasy_game

A tactical turn-based game project in pygame, open to support
GNU General Public License v3.0
405 stars 85 forks source link

SOLVED(#71) : Show default body when there is no events in the diary menu #73

Closed hadizamani021 closed 1 year ago

Grimmys commented 1 year ago

Hi hadi,

Ok, maybe I wasn't clear enough in the issue, because it's not exactly what I was thinking of. What you did is replacing the title in case of empty diary, but on my side I was thinking about just adding a default message to the body, instead of having an empty body, without changing the title.

So something like:

Diary (title)

No event has been recorded yet. (body content)

In terms of code, it means that the sentence would be inside of a TextElement, which would be itself in grid_elements.

Do you think you could adapt your solution this way?

Also small detail, it would be great if you can put a reference to the issue you are addressing if there is any, so that they could be link together. Like this way: #71

hadizamani021 commented 1 year ago

provided

Yes, you are right. Sorry, there was a misunderstood. I pushed new commits and tried to show the default message if the body is empty.

Grimmys commented 1 year ago

Looks good this time, thanks for your first contribution. 🥳