search

Grinnode-live / 2020-grin-bug-bash-challenge

Finding bugs in Grin-Wallet & Grin-nodes for a bounty prior to Grin fork v5.
3 stars 1 forks source link

[GRIN-Wallet] Test of wallet leaves TOR zombie processes #36

Closed marekyggdrasil closed 3 years ago

marekyggdrasil commented 3 years ago

Description Testing the verify payment proof method from the Owner API

Prerequisites

  1. GRIN-Node
  2. GRIN-Wallet

Test procedure

  1. Run GRIN-Wallet in Owner API listener mode
  2. Perform many TOR transactions
  3. Save output from system task manager such as top

Expected result:

Check if you can make TOR processes hang in the background as it was reported here https://github.com/mimblewimble/grin-wallet/issues/510

Provide requests and response full payloads as well as wallet and node logs.

mojitoo commented 3 years ago

how can i Perform many TOR transactions ? by opening multiple terminal ?

marekyggdrasil commented 3 years ago

I see the problem. Let's modify it a bit.

  1. Run wallet in owner API listener mode and check it's process ID
  2. Perform TOR transaction using another wallet and pay attention if TOR process gets spawned by the wallet
  3. When transaction is finalized expect TOR process to get killed.

Replicate for 1, 2, 3 transactions in parallel, if that is not sufficient we can open a new issue (harder) for a more elaborate test.

It's an open discussion what's the best way to check it. Feel free to leave your opinion, how you see it.

mojitoo commented 3 years ago

do you mean i need to perform a transaction from wallet 2 to wallet 1 running in owner api mode ?

mojitoo commented 3 years ago

Prerequisites:

After running the wallet in listener mode and make sure it was reachable, i can see by running top command that one tor process was spawned. After 3 consecutive transactions, wallet didn’t spawn another tor process but reused same one. after i turned off the listen mode, tor process was killed.

marekyggdrasil commented 3 years ago

I'm convinced. Looks good to me! Please just include your wallet version in the last comment by sending the output of

grin-wallet -V
mojitoo commented 3 years ago