Closed augensalat closed 3 years ago
Any SQL::Abstract extension I would write or include would not be SQLite specific since there are basically no SQLite-specific components to the extension (though there are some Pg specific components to the current Pg one). Thus it would not be part of this distribution.
So what do you mean? A CPAN distribution SQL-Abstract-WithOptions
which is basically the same as a SQL::Abstract::SQLite
and the lowest common denominator for most RDBMSes?
That is my idea yes, but mst would prefer that I wait for the SQL::Abstract redesign.
Oh, didn't know that. However I don't see right now how that redesign solves the issues here.
We're -very- nearly there SQL::Abstract wise, and in fact SQL::Abstract::Pg will effectively become obsolete once it ships.
I'm not sure what issues you have that don't appear to be solved - have a look through SQL::Abstract::Reference and the ExtraClauses plugin for a full feature set.
I didn't look so closely, but I think it does not have a LIMIT
/OFFSET
implementation.
But maybe this plugin system makes that simpler than how the current SQL::Abstract::$extension
classes do it.
SQL::Abstract::Pg is now available as a separate CPAN distribution, so it is now being used directly in 3.006.
Documentation suggests to use
SQL::Abstract::Pg
for extended SQL options. However the depedency chain for building that module, which is part ofMojo::Pg
is quite heavy. Can't we have aSQL::Abstract::SQLite
for and inMojo-SQLite
? If you don't want to write that yourself - would you accept a PR?